ENH/CoW: use lazy copy in set_axis method #49600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
requested changes
Nov 12, 2022
MarcoGorelli
requested changes
Nov 12, 2022
MarcoGorelli
approved these changes
Nov 12, 2022
| assert not np.shares_memory(get_array(df2, "a"), get_array(df, "a")) | ||
|
|
||
| # mutating df2 triggers a copy-on-write for that column / block | ||
| df2.iloc[0, 1] = 0 |
There was a problem hiding this comment.
Suggested change
| df2.iloc[0, 1] = 0 | |
| df2.iloc[0, 0] = 0 |
(just to keep it as simple as possible, for this test there is no reason to not take the first value/column)
|
And you will also have to merge the main branch, to resolve the conflict from merging your other PR |
73 tasks
|
@Th3nn3ss small reminder in case you have time to update for the minor comments above |
|
sorry about the delay @jorisvandenbossche I was preoccupied with my research project. I have made some changes. Thanks for taking a look at my PR. |
phofl
reviewed
Dec 24, 2022
ntachukwu
force-pushed
the
CoW_in_set_axis
branch
from
30d680e to
f5e1d5e
Compare
ntachukwu
requested review from
phofl
and removed request for
jorisvandenbossche
phofl
approved these changes
Dec 28, 2022
|
Thx @Th3nn3ss |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy-on-Write in
set_axisThis PR is part of an effort to implement the Copy-on-Write implementation mentioned in ENH / CoW: Use the "lazy copy" (with Copy-on-Write) optimization in more methods where appropriate #49473. More detail in this proposal https://docs.google.com/document/d/1ZCQ9mx3LBMy-nhwRl33_jgcvWo9IWdEfxDNQ2thyTb0/edit / with discussions in Proposal for future copy / view semantics in indexing operations #36195