Skip to content

BUG: groupby with sort=False still sorts an ordered categorical #49613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 10, 2022
Merged

BUG: groupby with sort=False still sorts an ordered categorical #49613

merged 2 commits into from
Nov 10, 2022

Conversation

rhshadrach
Copy link
Member

@rhshadrach rhshadrach added Bug Groupby Categorical Categorical Data Type labels Nov 10, 2022
mroeschke
mroeschke reviewed Nov 10, 2022
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I think this behavior is a lot more sane.

Could you update the groupby docstring to mention that sort dictates the order even when ordered=True?

@rhshadrach rhshadrach requested a review from mroeschke November 10, 2022 20:12
@mroeschke mroeschke added this to the 2.0 milestone Nov 10, 2022
@mroeschke mroeschke merged commit 9c05918 into pandas-dev:main Nov 10, 2022
@mroeschke
Copy link
Member

Thanks @rhshadrach

@rhshadrach rhshadrach deleted the cat_ordered_nosort branch November 10, 2022 20:39
codamuse pushed a commit to codamuse/pandas that referenced this pull request Nov 12, 2022
@rhshadrach @codamuse
BUG: groupby with sort=False still sorts an ordered categorical (pand…
a835fba 
…as-dev#49613)

* BUG: groupby with sort=False still sorts an ordered categorical

* Add versionchanged
mliu08 pushed a commit to mliu08/pandas that referenced this pull request Nov 27, 2022
@rhshadrach @mliu08
BUG: groupby with sort=False still sorts an ordered categorical (pand…
414ab21 
…as-dev#49613)

* BUG: groupby with sort=False still sorts an ordered categorical

* Add versionchanged
@j-bennet j-bennet mentioned this pull request Feb 26, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Bug Categorical Categorical Data Type Groupby
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

BUG: groupby with sort=False not respected for categorical data for MultiIndex with 2 grouping keys
2 participants
@rhshadrach @mroeschke