STYLE: fix pylint redefined-oute-name warnings (pandas-dev#49656) #49668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
suggested changes
Nov 12, 2022
pandas/core/internals/concat.py
Outdated
| from __future__ import annotations | ||
|
|
||
| import copy | ||
| import copy as _copy_ |
There was a problem hiding this comment.
how about import copy as stdlib_copy?
There was a problem hiding this comment.
right, i am working on that.
pandas/core/reshape/merge.py
Outdated
| from __future__ import annotations | ||
|
|
||
| import copy | ||
| import copy as _copy_ |
pandas/io/json/_json.py
Outdated
| return obj | ||
|
|
||
| def _get_object_parser(self, json) -> DataFrame | Series: | ||
| def _get_object_parser(self, json_object) -> DataFrame | Series: |
There was a problem hiding this comment.
if you're no longer import json, then can this argument stay the same?
pandas/io/json/_json.py
Outdated
| def __init__( | ||
| self, | ||
| json, | ||
| json_object, |
|
you'll need to run pre-commit checks (see the contributing guide for how to do that), but apart from that looks good |
MarcoGorelli
suggested changes
Nov 17, 2022
|
closing as stale, thanks anyway for your PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed warnings for the following files :-