BLD: use nonvendor versioneer #49924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 28, 2022
lithomas1
reviewed
Nov 28, 2022
| @@ -1,20 +1,25 @@ | |||
| # pylint: disable=consider-using-f-string | |||
There was a problem hiding this comment.
Were changes to this file made by versioneer? I'm surprised non vendored mode didn't get rid of it.
(I guess I'll just nuke it after we drop setuptools)
There was a problem hiding this comment.
Yes, this is from versioneer.
|
Does meson-Python require versioneer to be vendored? |
Seems to work fine. |
lithomas1
approved these changes
Nov 28, 2022
mroeschke
approved these changes
Nov 28, 2022
|
Awesome, thanks @fangchenli. Always great to not vendor things if we don't have to |
5 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
After this, we could enable PEP 517.