CI_check_correctness_notebooks #49935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Nov 28, 2022
MarcoGorelli
suggested changes
Nov 28, 2022
ci/code_checks.sh
Outdated
| @@ -12,9 +12,10 @@ | |||
| # $ ./ci/code_checks.sh doctests # run doctests | |||
| # $ ./ci/code_checks.sh docstrings # validate docstring errors | |||
| # $ ./ci/code_checks.sh single-docs # check single-page docs build warning-free | |||
| # $ ./ci/code_checks.sh notebooks # check correctness of documentation of notebooks | |||
There was a problem hiding this comment.
rather than 'correctness', which isn't really well-defined (😄 ), how about "check execution of documentation notebooks"?
There was a problem hiding this comment.
rather than 'correctness', which isn't really well-defined (😄 ), how about "check execution of documentation notebooks"?
Sure. Changed to the better wording in the second commit. Thank you, @MarcoGorelli
Thanks @mroeschke , added this in the second commit. |
MarcoGorelli
approved these changes
Nov 28, 2022
mroeschke
approved these changes
Nov 28, 2022
|
Awesome, thanks @natmokval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the PR #49874.
Creating new PR, that checks correctness notebooks, as was discussed with @MarcoGorelli .
CI didn't fail when documentation notebook executed with an error. I added new notebooks section in
ci/code_checks.shto check if the notebook execution passes.