Skip to content

CLN: MultiIndex._union #50574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 5, 2023
Merged

CLN: MultiIndex._union #50574

merged 2 commits into from
Jan 5, 2023

Conversation

lukemanley
Copy link
Member

No need to special-case missing/NA following the fix in #49442

Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have tests covering this?

Looks good otherwise

@lukemanley
Copy link
Member Author

We have tests covering this?

yes, a handful in pandas/tests/indexes/multi/test_setops.py:
test_union_with_missing_values_on_both_sides
test_union_nan_got_duplicated
test_union_keep_ea_dtype_with_na
test_union_with_na_when_constructing_dataframe

@phofl
Copy link
Member

phofl commented Jan 5, 2023

cc @lukemanley The Minimum versions failure could be legit, could you have a look? Might be possible that the PerformanceWarning is avoided now

@lukemanley
Copy link
Member Author

cc @lukemanley The Minimum versions failure could be legit, could you have a look? Might be possible that the PerformanceWarning is avoided now

Yep, looks like the PerformanceWarning is now avoided. I've removed the warning check.

@mroeschke mroeschke added this to the 2.0 milestone Jan 5, 2023
@mroeschke mroeschke merged commit 1d73a56 into pandas-dev:main Jan 5, 2023
@mroeschke
Copy link
Member

Thanks @lukemanley

@lukemanley lukemanley deleted the clean-mi-union branch January 19, 2023 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants