BUG: Series constructor overflowing for UInt64 #50757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Bug
NA - MaskedArrays
|
Yikes this is mean, it's not failing on Mac :) |
| ) | ||
| tm.assert_series_equal(result, expected) | ||
|
|
||
| def test_series_constructor_overflow_int_with_nan(self): |
There was a problem hiding this comment.
should this be "uint" instead of "int"?
| @@ -2007,6 +2008,50 @@ def test_series_constructor_ea_int_from_string_bool(self): | |||
| with pytest.raises(ValueError, match="invalid literal"): | |||
| Series(["True", "False", "True", pd.NA], dtype="Int64") | |||
|
|
|||
| @pytest.mark.parametrize("val", [1, 1.0]) | |||
| def test_series_constructor_overflow_uint_ea(self, val): | |||
There was a problem hiding this comment.
do these tests go through meaningfully different paths? if not id suggest combining them. not a big deal
There was a problem hiding this comment.
Expected is annoying to define in one df, so would prefer keeping it separate to make it easier to read
3 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Not sure if there is a way to avoid loss of precision without using object in the mixed case. This does not impact the regular case without overflow risks