DEPR: Remove ABC(Int|Uint|Float)64Index #50775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
force-pushed
the
remove_ABCInt/UInt/Float64Index
branch
from
f008912 to
4f13011
Compare
topper-123
changed the title
topper-123
force-pushed
the
remove_ABCInt/UInt/Float64Index
branch
from
4f13011 to
0d503ce
Compare
topper-123
commented
Jan 16, 2023
| Float64Index(np.arange(5, dtype="float64")), | ||
| Int64Index(np.arange(5, dtype="int64")), | ||
| UInt64Index(np.arange(5, dtype="uint64")), | ||
| # TODO: add more dtypes here |
There was a problem hiding this comment.
I've got some problems with arithmetics with non-64-bit indexes. I'd like to take them in a follow-up.
topper-123
force-pushed
the
remove_ABCInt/UInt/Float64Index
branch
from
05c23dd to
485eb10
Compare
|
All green now. |
phofl
reviewed
Jan 18, 2023
| @@ -669,15 +669,15 @@ def test_mul_int_array(self, numeric_idx): | |||
| result = idx * np.array(5, dtype="int64") | |||
| tm.assert_index_equal(result, idx * 5) | |||
|
|
|||
| arr_dtype = "uint64" if isinstance(idx, UInt64Index) else "int64" | |||
| arr_dtype = "uint64" if idx.dtype == np.uint64 else "int64" | |||
There was a problem hiding this comment.
Can we use is_unsigned_integer_dtype here? Ok as follow up
phofl
approved these changes
Jan 18, 2023
phofl
added
Deprecate
|
thx @topper-123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress towards #42717.