Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: remove Int/Uint/Float64Index from tests/arithmetic + various #50889

Merged

Conversation

topper-123
Copy link
Contributor

Progress towards #42717.

Arithmetic ops with indexes with 8/16/32 bit dtypes is a bit difficult and I'd like like to work on that after removal of Int64Index etc. So there's a follow-up, where more dtypes should be added to the tests in pandas/tests/arithmetic/.

@topper-123 topper-123 force-pushed the remove_num_indexes_from_test_arithmetic branch from de5d6ef to 083ac5d Compare January 20, 2023 12:20
@topper-123
Copy link
Contributor Author

The failure looks unrelated.

@mroeschke mroeschke added the Deprecate Functionality to remove in pandas label Jan 20, 2023
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (looks like this increases coverage with Series + dtype in some of these tests)

@mroeschke mroeschke added this to the 2.0 milestone Jan 20, 2023
@mroeschke mroeschke merged commit 32a655b into pandas-dev:main Jan 20, 2023
@mroeschke
Copy link
Member

Thanks @topper-123

@topper-123 topper-123 deleted the remove_num_indexes_from_test_arithmetic branch January 20, 2023 17:59
pooja-subramaniam pushed a commit to pooja-subramaniam/pandas that referenced this pull request Jan 25, 2023
…andas-dev#50889)

DEPR: remove Int/Uint/Float64Index from tests/arithmetic + various places
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants