REF: Define methods on resample non-dynamically #50913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -895,6 +895,74 @@ def asfreq(self, fill_value=None): | |||
| """ | |||
| return self._upsample("asfreq", fill_value=fill_value) | |||
|
|
|||
| def sum( | |||
There was a problem hiding this comment.
For these one that were left out, I couldn't inherit since the associated groupby doc contains numba arguments that are not supported by resample.
| *args, | ||
| **kwargs, | ||
| ): | ||
| nv.validate_resampler_func("max", args, kwargs) |
There was a problem hiding this comment.
looks like args/kwargs are getting ignored for many of these. can we just remove them?
There was a problem hiding this comment.
I think that would require a deprecation cycle like what was done in #50338, but I would be +1 for deprecating *args, **kwargs here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.