Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: move NumericIndex._format_native_types to Index #50931

Conversation

topper-123
Copy link
Contributor

@topper-123 topper-123 commented Jan 22, 2023

This starts moving functionality from NumericIndexto Index in preparation to remove NumericIndex and include numpy int/uint/float64 in the base Index.

Also removes the **kwargs, as that wasn't used in the method.

I'm doing one method per PR, figuring that is easier to review. I could add ore per PR if you want.

xref #42717.

@topper-123 topper-123 force-pushed the move_NumericIndex._format_native_types_to_Index branch from 0693cab to 02e5715 Compare January 23, 2023 12:04
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbrockmendel jbrockmendel merged commit ef6c35c into pandas-dev:main Jan 23, 2023
@jbrockmendel
Copy link
Member

thanks @topper-123

iofall pushed a commit to iofall/pandas that referenced this pull request Jan 23, 2023
* DEPR: move NumericIndex._format_native_types to Index

* fix date_format parameter

* fix mypy issue
@topper-123 topper-123 deleted the move_NumericIndex._format_native_types_to_Index branch January 23, 2023 20:19
pooja-subramaniam pushed a commit to pooja-subramaniam/pandas that referenced this pull request Jan 25, 2023
* DEPR: move NumericIndex._format_native_types to Index

* fix date_format parameter

* fix mypy issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants