DEPR: Remove NumericIndex from tests/arithmetic/ #51100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
force-pushed
the
remove_NumericIndex_from_tests/arithmetic
branch
from
01177ad
to
ca31c30
Compare
phofl
approved these changes
Feb 1, 2023
|
thx @topper-123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
NumericIndexfrompandas/tests/arithemetic/.I've tried quite a lot to generalize the tests here to be for all the numeric numpy dtypes, but it seems almost impossible. The main issue is that numexpr operations behave differently for many dtypes lower than 64-bit than python ones, and its behaviour just seems unpredictably different than the normal python ops.
The tests in this directory concern both indexes and series and non-64-bit dtypes weren't tested before, even though it was possible for Series, and I assume the reason for that is the same difficulty, though I don't know for sure.
xref #42717.