-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REF: implement groupby std, min, max as EA methods #51116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There any performance impact here?
Not directly, but a big part of the idea is to make it easier to implement performant implementations for our pyarrow arrays (and in my daydreams, for 3rd party authors to do Distributed/GPU EA implementations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both the direction this moves toward and the implementation look good to me. cc @mroeschke @jorisvandenbossche
Does any/all/std for sure need a different API then |
Okay so IIUC, |
Yes. Though at this point I'm almost ready to close this. |
Closing in favor of #52089 |
xref #51003 does the same thing for quantile
xref #43682 asking for something similar (but not for these particular reductions)
Allows EA authors to implement performant implementations (including us for e.g. pyarrow dtypes).