Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: Remove NumericIndex from tests/indexes/test_numpy_compat.py #51132

Merged
merged 1 commit into from
Feb 3, 2023
Merged

DEPR: Remove NumericIndex from tests/indexes/test_numpy_compat.py #51132

merged 1 commit into from
Feb 3, 2023

Conversation

topper-123
Copy link
Contributor

This was a bit tricky.

xref #42717.

@topper-123 topper-123 mentioned this pull request Feb 3, 2023
Merged
2 tasks
phofl
phofl approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes these if conditions were complicated...

@phofl phofl added the Deprecate Functionality to remove in pandas label Feb 3, 2023
@phofl phofl added this to the 2.0 milestone Feb 3, 2023
@phofl phofl merged commit b65551c into pandas-dev:main Feb 3, 2023
@topper-123 topper-123 deleted the remove_NumericIndex_test_numpy_compat.py branch February 3, 2023 10:36
@topper-123 topper-123 added the Index Related to the Index class or subclasses label Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Index Related to the Index class or subclasses
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@topper-123 @phofl