ENH: Index set operations with sort=True #51346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Feb 13, 2023
| try: | ||
| result = algos.safe_sort(result) | ||
| except TypeError as err: | ||
| if sort is True: |
There was a problem hiding this comment.
Do we have tests for these "stricter" raising behavior?
There was a problem hiding this comment.
Yes, they’re xfailed in main
mroeschke
approved these changes
Feb 13, 2023
|
Thanks @jbrockmendel |
2 tasks
3 tasks
galipremsagar
added a commit
to rapidsai/cudf
that referenced
this pull request
Dec 29, 2023
…14681) This PR sorts results in `Index.difference` & `union` in the early exit scenarios similar to: pandas-dev/pandas#51346 On `pandas_2.0_feature_branch`: ``` = 110 failed, 101331 passed, 2091 skipped, 952 xfailed, 312 xpassed in 1064.30s (0:17:44) = ``` This PR: ``` = 87 failed, 101354 passed, 2091 skipped, 952 xfailed, 312 xpassed in 1004.34s (0:16:44) = ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.