TYP: fix NDFrame.align #51867
TYP: fix NDFrame.align #51867
Conversation
pyright_reportGeneralTypeIssues.json
Outdated
| @@ -1,4 +1,3 @@ | |||
| # this becomes obsolete when reportGeneralTypeIssues can be enabled in pyproject.toml | |||
There was a problem hiding this comment.
Had to remove these comments as the JSON format does not allow comments (pyright seems to use a stricter parser now)
There was a problem hiding this comment.
what happens if you dont upgrade pyright?
There was a problem hiding this comment.
Upgrading pyright is not needed for this PR. Just upgraded it because there is a newer version.
There was a problem hiding this comment.
OK. everything but this im happy to merge. for this can we ping someone who knows pyright better than me?
There was a problem hiding this comment.
I reverted this change for this PR as it is not yet needed.
pandas/core/generic.py
Outdated
| @@ -198,6 +199,8 @@ | |||
| from pandas.core.indexers.objects import BaseIndexer | |||
| from pandas.core.resample import Resampler | |||
|
|
|||
| _NDFrameT = TypeVar("_NDFrameT", bound="NDFrame") | |||
There was a problem hiding this comment.
can you add a comment on why this is necessary? e.g. i think once Self is available we can swap this out?
There was a problem hiding this comment.
Yes, this can be removed when we can use Self. If we want to link two parameters to be of the same NDFrame (sub-class) NDFrameT is enough, but if we have two pairs, we need to use a second TypeVar for the second pair. Otherwise, all four parameters are bound to the same (sub)class.
There was a problem hiding this comment.
i know, im asking for a comment in the code to that effect
There was a problem hiding this comment.
Added a comment. I realized that we cannot remove it when Self is available as Self doesn't help _align_as_utc.
There was a problem hiding this comment.
Probably better to move it to pandas._typing since this will not be a temporary fix.
There was a problem hiding this comment.
i think when the time comes we can make _align_as_utc a NDFrame method
There was a problem hiding this comment.
moved to pandas._typing
|
one comment request, otherwise LGTM |
|
thanks @twoertwein |
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.