Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLD: remove libreduction #52660

Merged
merged 1 commit into from
Apr 14, 2023
Merged

BLD: remove libreduction #52660

merged 1 commit into from
Apr 14, 2023

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@mroeschke
Copy link
Member

Guessing the slowdown is not that great?

@mroeschke mroeschke added the Build Library building on various platforms label Apr 13, 2023
@jbrockmendel
Copy link
Member Author

Guessing the slowdown is not that great?

Neglible

lithomas1
lithomas1 approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@lithomas1 lithomas1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@lithomas1 lithomas1 added this to the 2.1 milestone Apr 14, 2023
@mroeschke mroeschke merged commit eb58298 into pandas-dev:main Apr 14, 2023
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the bld-size branch April 14, 2023 16:57
@rhshadrach rhshadrach mentioned this pull request Jul 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@lithomas1 lithomas1 lithomas1 approved these changes

Assignees
No one assigned
Labels
Build Library building on various platforms
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @mroeschke @lithomas1