Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: tz_localize with ArrowDtype #52677

Merged
merged 7 commits into from
Apr 18, 2023

Conversation

mroeschke
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@mroeschke mroeschke added Timezones Timezone data dtype Arrow pyarrow functionality labels Apr 14, 2023
@mroeschke mroeschke added this to the 2.0.1 milestone Apr 14, 2023
"nonexistent, exp_date",
[
["shift_forward", datetime(year=2023, month=3, day=12, hour=3)],
["shift_backward", pd.Timestamp("2023-03-12 01:59:59.999999999")],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this copied from a non-pyarrow analogue? before too long we should really look at putting these in one place and parametrizing them

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, I came up with this example independently. It would be good to parameterize this with the existing tz_localize tests eventually.

@jbrockmendel
Copy link
Member

comment on test org, otherwise LGTM

@mroeschke mroeschke merged commit ff8e88a into pandas-dev:main Apr 18, 2023
@mroeschke mroeschke deleted the bug/arrow/tz_localize branch April 18, 2023 16:56
@lumberbot-app
Copy link

lumberbot-app bot commented Apr 18, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.0.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 ff8e88a05c907bd124bcfcf3c5384e16a7987cc7
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #52677: BUG: tz_localize with ArrowDtype'
  1. Push to a named branch:
git push YOURFORK 2.0.x:auto-backport-of-pr-52677-on-2.0.x
  1. Create a PR against branch 2.0.x, I would have named this PR:

"Backport PR #52677 on branch 2.0.x (BUG: tz_localize with ArrowDtype)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arrow pyarrow functionality Timezones Timezone data dtype
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants