Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: Added test on dataframe constructor with None #52727

Merged
merged 2 commits into from
Apr 19, 2023
Merged

TST: Added test on dataframe constructor with None #52727

merged 2 commits into from
Apr 19, 2023

Conversation

Gramet
Copy link
Contributor

@Gramet Gramet commented Apr 18, 2023

This test should cover what happened in issue #32218.

@phofl @noatamir @jorisvandenbossche @MarcoGorelli

@noatamir noatamir added the Sprints Sprint Pull Requests label Apr 18, 2023
MarcoGorelli
MarcoGorelli approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks @Gramet

@mroeschke mroeschke added this to the 2.1 milestone Apr 19, 2023
@mroeschke mroeschke merged commit 15735a1 into pandas-dev:main Apr 19, 2023
@mroeschke
Copy link
Member

Thanks @Gramet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Sprints Sprint Pull Requests
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

Inconsistent behavior when DataFrame with strings and None is created from lists or dictionary.
4 participants
@Gramet @mroeschke @MarcoGorelli @noatamir