CLN: some cleanups in Series.apply & related #52786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
changed the title
mroeschke
approved these changes
Apr 19, 2023
|
Thanks @topper-123 |
|
it looks like this caused a performance regression https://asv-runner.github.io/asv-collection/pandas/#join_merge.ConcatDataFrames.time_c_ordered?p-axis=0 could you take a closer look? |
|
I've bisected this and the regression is actually caused by #52685. |
|
thx, this pr looked weird, but didn't have time to investigate more. The other makes more sense |
m-richards
added a commit
to m-richards/geopandas
that referenced
this pull request
Jul 23, 2023
jorisvandenbossche
pushed a commit
to jorisvandenbossche/geopandas
that referenced
this pull request
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleanups:
convert_dtypewarning fromSeries.applytoSeriesApply*,to force use use of keywordsconvert_dtypeinSeriesApplytono_defaultconvert_dtypeinternally inSeries.agg&Series.transform(these are noops, i.e. have no effect)