Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST #24205: test_groupby_nth_interval created for Groupby Nth with Multindex Inverval #52968

Merged
merged 5 commits into from
Apr 29, 2023
Merged

TST #24205: test_groupby_nth_interval created for Groupby Nth with Multindex Inverval #52968

merged 5 commits into from
Apr 29, 2023

Conversation

ltartaro
Copy link
Contributor

@ltartaro
Copy link
Contributor Author

The CI minimum version failed with the following message:
Error: The runner has received a shutdown signal...' in GHA. GH 45651

Since I only added a test in this PR and all other tests pass, I think the error is unrelated to the changes made.

@rhshadrach rhshadrach added Groupby Needs Tests Unit test(s) needed to prevent regressions Filters e.g. head, tail, nth labels Apr 28, 2023
rhshadrach
rhshadrach requested changes Apr 28, 2023
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good, just one small nit.

pandas/tests/groupby/test_nth.py Outdated Show resolved Hide resolved
@rhshadrach rhshadrach added this to the 2.1 milestone Apr 28, 2023
mroeschke
mroeschke requested changes Apr 28, 2023
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you undo the file permission change on this file? Looks like it changed to 100755

mroeschke
mroeschke approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM merge when ready @rhshadrach

rhshadrach
rhshadrach approved these changes Apr 29, 2023
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach merged commit a3c9a5c into pandas-dev:main Apr 29, 2023
@rhshadrach
Copy link
Member

Thanks @ltartaro!

NumanIjaz pushed a commit to NumanIjaz/pandas that referenced this pull request May 1, 2023
@ltartaro @NumanIjaz
TST: groupby.nth with MultiIndex Interval (pandas-dev#52968)
0dfa498
topper-123 pushed a commit to topper-123/pandas that referenced this pull request May 7, 2023
@ltartaro @topper-123
TST: groupby.nth with MultiIndex Interval (pandas-dev#52968)
2db0f09
Rylie-W pushed a commit to Rylie-W/pandas that referenced this pull request May 19, 2023
@ltartaro
TST: groupby.nth with MultiIndex Interval (pandas-dev#52968)
4b52854
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
@ltartaro
TST: groupby.nth with MultiIndex Interval (pandas-dev#52968)
ac6b9a9
@code-narrator code-narrator mentioned this pull request Sep 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhshadrach rhshadrach rhshadrach approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Filters e.g. head, tail, nth Groupby Needs Tests Unit test(s) needed to prevent regressions
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

pd.core.groupby.groupby.DataFrameGroupBy.nth yielding false values with Interval MultiIndex Interval
3 participants
@ltartaro @rhshadrach @mroeschke