Skip to content

REF: remove axis keyword from Manager/Block.shift #53845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 27, 2023
Merged

REF: remove axis keyword from Manager/Block.shift #53845

merged 6 commits into from
Jun 27, 2023

Conversation

jbrockmendel
Copy link
Member

This adds an assertion to NDFrame.shift that won't be Technically Correct until #53832 is merged.

@mroeschke
Copy link
Member 

mypy.......................................................................Failed
- hook id: mypy
- duration: 214.27s
- exit code: 1

pandas/core/internals/blocks.py:1492: error: Incompatible return value type (got "List[Block]", expected "List[Self]")  [return-value]
pandas/core/internals/blocks.py:1497: error: List item 0 has incompatible type "Block"; expected "Self"  [list-item]
Found 2 errors in 1 file (checked 1418 source files)

mypy (stubtest)............................................................Failed
- hook id: stubtest
- duration: 122.98s
- exit code: 1

error: not checking stubs due to mypy build errors:
pandas/core/internals/blocks.py:1492: error: Incompatible return value type (got "List[Block]", expected "List[Self]")  [return-value]
pandas/core/internals/blocks.py:1497: error: List item 0 has incompatible type "Block"; expected "Self"  [list-item]

@mroeschke mroeschke added Refactor Internal refactoring of code Internals Related to non-user accessible pandas implementation labels Jun 26, 2023
@jbrockmendel
Copy link
Member Author

rebased+green

@mroeschke mroeschke added this to the 2.1 milestone Jun 27, 2023
@mroeschke mroeschke merged commit 9d676a9 into pandas-dev:main Jun 27, 2023
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the ref-ea-axis branch June 27, 2023 17:26
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
@jbrockmendel
REF: remove axis keyword from Manager/Block.shift (pandas-dev#53845)
0bf1e55 
* REF: remove axis keyword from Manager/Block.shift

* mypy fixup

* mypy fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees

No one assigned

Labels

Internals Related to non-user accessible pandas implementation Refactor Internal refactoring of code

Projects

None yet

Milestone

2.1

Development

Successfully merging this pull request may close these issues.

2 participants

@jbrockmendel @mroeschke