Fix deprecation warning on Python 3.12 #54188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Constant.n` is now deprecated for removal in 3.14; it appears that `Constant.value` has existed since at least 3.9.
mroeschke
reviewed
Jul 19, 2023
| @@ -550,7 +550,7 @@ def visit_Num(self, node, **kwargs) -> Term: | |||
| return self.const_type(node.n, self.env) | |||
|
I already have a PR for this #53743. Thanks for the effort though. |
|
Thanks for the PR, but since this is covered in #53743 will close in favor of that PR |
|
Oops, thought I looked for existing ones; not sure why I didn't find it earlier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constant.nis now deprecated for removal in 3.14; it appears thatConstant.valuehas existed since at least 3.9.doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.