Skip to content

BUG: pivot_table mean of integer input casted back to int #54263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 2, 2023

Conversation

austinauyeung
Copy link
Contributor

Remove downcasting and update tests to expect floats according to #16676 (comment).

@mroeschke mroeschke requested a review from rhshadrach July 26, 2023 17:49
@mroeschke mroeschke added Groupby Dtype Conversions Unexpected or buggy dtype conversions labels Jul 26, 2023
@austinauyeung austinauyeung marked this pull request as ready for review July 27, 2023 03:33
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rhshadrach rhshadrach added Reshaping Concat, Merge/Join, Stack/Unstack, Explode API - Consistency Internal Consistency of API/Behavior and removed Groupby labels Jul 28, 2023
@rhshadrach rhshadrach added this to the 2.1 milestone Jul 28, 2023
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach merged commit c30626e into pandas-dev:main Aug 2, 2023
@rhshadrach
Copy link
Member

Thanks @austinauyeung!

@austinauyeung
Copy link
Contributor Author

Thanks for the code review @rhshadrach!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API - Consistency Internal Consistency of API/Behavior Bug Dtype Conversions Unexpected or buggy dtype conversions Groupby Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG / ENH: Implement groupby_helper funcs for int
3 participants