Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docstring of Index.join in base.py #55050

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Fix docstring of Index.join in base.py #55050

merged 1 commit into from
Sep 7, 2023

Conversation

kmuehlbauer
Copy link
Contributor

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@kmuehlbauer kmuehlbauer mentioned this pull request Sep 7, 2023
Closed
@kmuehlbauer
Copy link
Contributor Author

That's a very strange thing and it's better if pandas devs can have a closer look here.

I can see the Examples have been added with #53403 but there is no sign of any failure. Everything looks good over there (cc @DeaMariaLeon @MarcoGorelli).

@kmuehlbauer
Copy link
Contributor Author

Everything looks good over there (

I did not look far down enough. The "Examples" heading is indeed one space to far to the right. So this PR should fix it.

@mroeschke mroeschke added the Docs label Sep 7, 2023
@mroeschke mroeschke added this to the 2.2 milestone Sep 7, 2023
@mroeschke mroeschke merged commit b1e9b58 into pandas-dev:main Sep 7, 2023
@mroeschke
Copy link
Member

Nice thanks @kmuehlbauer

@kmuehlbauer kmuehlbauer deleted the patch-1 branch September 8, 2023 05:32
mroeschke pushed a commit to mroeschke/pandas that referenced this pull request Sep 11, 2023
@kmuehlbauer @mroeschke
Fix docstring of Index.join in base.py (pandas-dev#55050)
5524d8a
@kmuehlbauer kmuehlbauer mentioned this pull request Sep 15, 2023
Merged
1 task
@kmuehlbauer
Copy link
Contributor Author

@mroeschke @lithomas1 Could this be included into 2.1.1? This breaks doc-building downstream.

@lithomas1 lithomas1 modified the milestones: 2.2, 2.1.1 Sep 20, 2023
@lithomas1
Copy link
Member

@meeseeksdev backport 2.1.x

@meeseeksmachine meeseeksmachine mentioned this pull request Sep 20, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Sep 20, 2023
@kmuehlbauer @meeseeksmachine
Backport PR pandas-dev#55050: Fix docstring of Index.join in base.py
5bf5f62
lithomas1 pushed a commit that referenced this pull request Sep 20, 2023
@meeseeksmachine @kmuehlbauer @phofl
Backport PR #55050 on branch 2.1.x (Fix docstring of Index.join in ba…
34cc5b7 
…se.py) (#55217)

Backport PR #55050: Fix docstring of Index.join in base.py

Co-authored-by: Kai Mühlbauer <kmuehlbauer@wradlib.org>
Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
2.1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@kmuehlbauer @mroeschke @lithomas1