DEPR offsets: rename ‘Y’ to ‘YE' #55792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natmokval
added
Deprecate
|
@MarcoGorelli, could you please take a look at this PR? Looks like CI failures are unrelated to my changes ( |
3 tasks
MarcoGorelli
reviewed
Nov 6, 2023
MarcoGorelli
reviewed
Nov 9, 2023
pandas/_libs/tslibs/offsets.pyx
Outdated
| @@ -4762,6 +4763,13 @@ cpdef to_offset(freq, bint is_period=False): | |||
| f"instead of \'{name}\'" | |||
| ) | |||
| elif is_period is True and name in c_OFFSET_DEPR_FREQSTR: | |||
| if name.startswith("A"): | |||
| warnings.warn( | |||
| f"\'{name}\' will be deprecated, please use " | |||
There was a problem hiding this comment.
can we change "will be deprecated" to "is deprecated and will be removed in a future version"?
There was a problem hiding this comment.
yes, I changed the warning message and updated my PR.
4 tasks
tacaswell
added a commit
to tacaswell/pandas
that referenced
this pull request
May 29, 2024
The PRs pandas-dev#55792 (Y), pandas-dev#52064 (Q), and pandas-dev#55553 (M) deprecated the single letter version of the aliases in favour of the -end version of them. This table was missed as part of that work.
5 tasks
tacaswell
added a commit
to tacaswell/pandas
that referenced
this pull request
May 29, 2024
The PRs pandas-dev#55792 (Y), pandas-dev#52064 (Q), and pandas-dev#55553 (M) deprecated the single letter version of the aliases in favour of the -end version of them. Add a note to the offset table about deprecations.
MarcoGorelli
pushed a commit
that referenced
this pull request
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #9586, #52064
Deprecated the alias denoting year end frequency “Y” for offsets in favour of “YE".