BUG: DataFrame.join inconsistently setting result index name #56948

lukemanley · 2024-01-19T01:02:55Z

closes BUG: Left join on index with non-unique values removes name of index #55815
Tests added and passed if fixing a bug or adding a new feature
All code checks passed.
Added type annotations to new arguments/methods/functions.
Added an entry in the latest doc/source/whatsnew/v2.3.0.rst file if fixing a bug or adding a new feature.

rhshadrach

lgtm. I noticed a small cleanup but doesn't have to be handled here.

pandas/tests/indexes/numeric/test_join.py

mroeschke · 2024-01-23T00:35:08Z

mroeschke · 2024-01-25T17:58:33Z

I discovered that there's a get_op_result_name. Looks like it's mostly used numerical ops/combine as of now. Maybe we should be using that here

lukemanley added 2 commits January 18, 2024 19:57

Index.join result name

db1f094

whatsnew

7ed5207

lukemanley added Bug Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Jan 19, 2024

lukemanley added this to the 3.0 milestone Jan 19, 2024

rhshadrach approved these changes Jan 19, 2024

View reviewed changes

pandas/tests/indexes/numeric/test_join.py Show resolved Hide resolved

lukemanley added 3 commits January 19, 2024 17:53

Merge remote-tracking branch 'upstream/main' into index-join-result-name

319d470

update test

5bd6856

Merge remote-tracking branch 'upstream/main' into index-join-result-name

e5937ff

mroeschke approved these changes Jan 23, 2024

View reviewed changes

mroeschke merged commit fe244ba into pandas-dev:main Jan 23, 2024

lukemanley mentioned this pull request Jan 26, 2024

BUG: Index.join with different names doesn't return None name #57074

Closed

5 tasks

Provide feedback