Skip to content

BUG: Fix to_dict with datelike types and orient=list #57157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2024
Merged

BUG: Fix to_dict with datelike types and orient=list #57157

merged 1 commit into from
Jan 31, 2024

Conversation

@mroeschke
Copy link
Member

@mroeschke mroeschke commented Jan 30, 2024 •
edited
Loading

@mroeschke mroeschke added the Bug label Jan 30, 2024
@WillAyd
Copy link
Member

WillAyd commented Jan 31, 2024

Very nice. In a similar vein I opened issue #57063 - I wonder what other places we have in the code base where we have historically exposed nanoseconds-since-epoch values out to end users. Would be nice to get rid of all of them I think

@mroeschke mroeschke added this to the 2.2.1 milestone Jan 31, 2024
@mroeschke mroeschke merged commit b41ea09 into pandas-dev:main Jan 31, 2024
@mroeschke mroeschke deleted the bug/to_dict branch January 31, 2024 00:18
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jan 31, 2024
@mroeschke @meeseeksmachine
Backport PR pandas-dev#57157: BUG: Fix to_dict with datelike types an…
daa2523 
…d orient=list
@meeseeksmachine meeseeksmachine mentioned this pull request Jan 31, 2024
Merged
mroeschke added a commit that referenced this pull request Jan 31, 2024
@meeseeksmachine @mroeschke
Backport PR #57157 on branch 2.2.x (BUG: Fix to_dict with datelike ty…
f6fd475 
…pes and orient=list) (#57160)

Backport PR #57157: BUG: Fix to_dict with datelike types and orient=list

Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
@mroeschke @pmhatre1
BUG: Fix to_dict with datelike types and orient=list (pandas-dev#57157)
bcf1a77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees

No one assigned

Labels

Bug

Projects

None yet

Milestone

2.2.1

Development

Successfully merging this pull request may close these issues.

BUG: Regression from 2.1 -> 2.2: df.to_dict produces int instead of timestamp

2 participants

@mroeschke @WillAyd