Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Report how far off the formatting is #57667

Merged
merged 2 commits into from
Feb 28, 2024
Merged

ENH: Report how far off the formatting is #57667

merged 2 commits into from
Feb 28, 2024

Conversation

larsoner
Copy link
Contributor

@larsoner larsoner commented Feb 28, 2024 •
edited
Loading

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Not sure this warrants a test change or whatsnew entry but I can add it if requested -- just takes the error message and makes it more informative:

E   UserWarning: Cell contents too long (54416), truncated to 32767 characters

@larsoner larsoner requested a review from rhshadrach as a code owner February 28, 2024 20:34
rhshadrach
rhshadrach approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, this warning is just being added for 3.0, so no need for an addition to the whatsnew.

@rhshadrach rhshadrach added IO Excel read_excel, to_excel Warnings Warnings that appear or should be added to pandas Enhancement labels Feb 28, 2024
@rhshadrach rhshadrach added this to the 3.0 milestone Feb 28, 2024
@rhshadrach rhshadrach merged commit e14a9bd into pandas-dev:main Feb 28, 2024
57 checks passed
@rhshadrach
Copy link
Member

Thanks @larsoner!

@larsoner larsoner deleted the how_bad branch February 28, 2024 22:56
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
@larsoner @pmhatre1
ENH: Report how far off the formatting is (pandas-dev#57667)
3c4f4e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhshadrach rhshadrach rhshadrach approved these changes

Assignees
No one assigned
Labels
Enhancement IO Excel read_excel, to_excel Warnings Warnings that appear or should be added to pandas
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@larsoner @rhshadrach