Skip to content

Conversation

natmokval
Copy link
Contributor

@natmokval natmokval commented Mar 17, 2024

xref #52064, #54939
replaced deprecated frequencies H and M with correct h and ME in tests for plotting, marked as @pytest.mark.xfail

@natmokval natmokval added Clean Frequency DateOffsets labels Mar 20, 2024
@natmokval natmokval marked this pull request as ready for review March 20, 2024 20:41
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @natmokval !

@MarcoGorelli MarcoGorelli added this to the 3.0 milestone Mar 21, 2024
@MarcoGorelli MarcoGorelli merged commit cfe191d into pandas-dev:main Mar 21, 2024
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
…ting (pandas-dev#57877)

cln: correct deprecated freqs H, M in tests for plotting
@rhshadrach
Copy link
Member

I'm having trouble determining whether this deprecation has been fully enforced. It remains unchecked in #50578, but I've tried a few tests here with the deprecated behavior and they seem to raise now. Do you know @MarcoGorelli or @natmokval?

@MarcoGorelli
Copy link
Member

hey - my recollection is that this was fully enforced, do you agree @natmokval ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants