-
-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: set __module__ for pandas scalars (Timestamp/Timedelta/Period) #57976
ENH: set __module__ for pandas scalars (Timestamp/Timedelta/Period) #57976
Conversation
Thanks for the PR! Can you add those new cases to the existing test that was added here: https://github.com/pandas-dev/pandas/pull/55171/files#diff-f2ce09edfcd4e105695b327053c3d288fa9547b1b5cb6488da3f3213e5478870? |
pandas/_libs/interval.pyx
Outdated
@set_module("pandas") | ||
cdef class Interval(IntervalMixin): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Interval, it seems this is not working (see the build failures) because this is a cdef class
instead of just a class
.
I don't directly know the best workaround, but so can also leave out Interval from this PR and already do the others
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK will do.
59f66a8
to
0545c4e
Compare
0545c4e
to
e8e7bbd
Compare
There is another failing test that needs to be updated: pandas/pandas/tests/tslibs/test_timezones.py Lines 144 to 146 in 4f145b3
The expected |
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the slow follow-up, but rebased this once more and fixed the docstring failure, so all good to go now.
@YinonHorev thanks again for the PR!
Addresses part of #55178