Skip to content

BUG: DataFrame slice selection treated as hashable in Python 3.12 #57500 #58043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 16, 2024
Merged

BUG: DataFrame slice selection treated as hashable in Python 3.12 #57500 #58043

merged 10 commits into from
Apr 16, 2024

Conversation

@tehunter
Copy link
Contributor

@tehunter tehunter changed the title Bugfix slice selection BUG: DataFrame slice selection treated as hashable in Python 3.12 #57500 Mar 28, 2024
@tehunter
Copy link
Contributor Author

My commits are out of order, but I confirmed the unit test behaves correctly by backing out the bug fix and running my unit test on 3.12. As expected, it failed.

mroeschke
mroeschke reviewed Apr 1, 2024
View reviewed changes
mroeschke
mroeschke reviewed Apr 1, 2024
View reviewed changes
@mroeschke mroeschke added Indexing Related to indexing on series/frames, not to indexes themselves MultiIndex labels Apr 1, 2024
@tehunter tehunter requested a review from mroeschke April 15, 2024 13:19
mroeschke
mroeschke reviewed Apr 15, 2024
View reviewed changes
mroeschke
mroeschke reviewed Apr 15, 2024
View reviewed changes
mroeschke
mroeschke reviewed Apr 16, 2024
View reviewed changes
@mroeschke mroeschke added this to the 3.0 milestone Apr 16, 2024
@mroeschke mroeschke merged commit 53bd1a8 into pandas-dev:main Apr 16, 2024
@mroeschke
Copy link
Member

Thanks @tehunter

@Aloqeely Aloqeely mentioned this pull request May 7, 2024
Closed
3 tasks
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
@tehunter @mroeschke @pmhatre1
BUG: DataFrame slice selection treated as hashable in Python 3.12 pan…
f96c5a1 
…das-dev#57500 (pandas-dev#58043)

* Reorder slice and hashable in __getitem__

* Add unit test

* Fix test and formatting

* Update whatsnew

* Restore original flow ordering

* Move whatsnew entry to 3.0.0

* Move whatsnew entry to Indexing

* Update doc/source/whatsnew/v3.0.0.rst

---------

Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
@yuji38kwmt yuji38kwmt mentioned this pull request Oct 4, 2024
Closed
3 tasks
@matiaslindgren matiaslindgren mentioned this pull request Oct 23, 2025
Open
3 tasks
@rhshadrach
Copy link
Member

@mroeschke - you okay with backporting this?

Ref: #61675 (comment)

@mroeschke
Copy link
Member

you okay with backporting this?

Sure, fine by me

@rhshadrach
Copy link
Member

@meeseeksdev backport to 2.3.x

@rhshadrach rhshadrach modified the milestones: 3.0, 2.3.4 Oct 23, 2025
@lumberbot-app
Copy link

lumberbot-app bot commented Oct 23, 2025

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.3.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 53bd1a83a987cad854f53db48a4d472dfeffdced
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #58043: BUG: DataFrame slice selection treated as hashable in Python 3.12 #57500'
  1. Push to a named branch:
git push YOURFORK 2.3.x:auto-backport-of-pr-58043-on-2.3.x
  1. Create a PR against branch 2.3.x, I would have named this PR:

"Backport PR #58043 on branch 2.3.x (BUG: DataFrame slice selection treated as hashable in Python 3.12 #57500)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

rhshadrach pushed a commit to rhshadrach/pandas that referenced this pull request Oct 23, 2025
@tehunter @rhshadrach
Backport PR pandas-dev#58043: BUG: DataFrame slice selection treated …
064bc12 
…as hashable in Python 3.12 pandas-dev#57500
rhshadrach added a commit to rhshadrach/pandas that referenced this pull request Oct 23, 2025
@rhshadrach
DOC: Move whatsnew note for pandas-dev#58043 to v2.3.4
e3a902a
@rhshadrach rhshadrach mentioned this pull request Oct 23, 2025
Open
5 tasks
@matiaslindgren matiaslindgren mentioned this pull request Oct 24, 2025
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees

No one assigned

Labels

Indexing Related to indexing on series/frames, not to indexes themselves MultiIndex

Projects

None yet

Milestone

2.3.4

Development

Successfully merging this pull request may close these issues.

BUG: Columns resulting from joining multiIndex dataFrame are incorrect in python 3.12.1

3 participants

@tehunter @mroeschke @rhshadrach