Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPS: Drop Python 3.9 #58238

Merged
merged 33 commits into from
Jun 21, 2024
Merged

DEPS: Drop Python 3.9 #58238

merged 33 commits into from
Jun 21, 2024

Conversation

mroeschke
Copy link
Member

Dropping Python 3.9 support per NEP 29 and SPEC-0

@mroeschke mroeschke added the Dependencies Required and optional dependencies label Apr 12, 2024
@@ -40,7 +40,6 @@ classifiers = [
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3 :: Only',
'Programming Language :: Python :: 3.8',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should Python :: 3.8 be removed as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Yes definitely

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This is a testing file so not critical but still useful)

@twoertwein
Copy link
Member

I think there are a few sys.version_info left that compare aginst 3.10, for example, in pandas._typing. Pyupgrades's --py310-plus might take care of that automatically (currently set to 3.9)

Copy link
Contributor

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only looked at _typing.py

pandas/_typing.py Show resolved Hide resolved
@mroeschke mroeschke added this to the 3.0 milestone Apr 15, 2024
@mroeschke mroeschke added the Build Library building on various platforms label Apr 15, 2024
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Do we want to wait until we get closer to 3.0 release to merge?

@mroeschke
Copy link
Member Author

Do we want to wait until we get closer to 3.0 release to merge?

I guess we could merge anytime, but I would wait a little just in case people are still using 3.9 nightlies

@lithomas1
Copy link
Member

Are people OK with doing this now?

We're coming up on the Python 3.10 drop date (end of this year) as well.

I would personally prefer dropping as close to the date specified by SPEC 0, so people aren't surprised when this happens.

@mroeschke
Copy link
Member Author

Since it seemed like there was approval a few months ago, I'll merge at the end of the week if there are no objections

@WillAyd
Copy link
Member

WillAyd commented Jun 18, 2024

Works for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms Dependencies Required and optional dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants