-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEPS: Drop Python 3.9 #58238
DEPS: Drop Python 3.9 #58238
Conversation
scripts/tests/data/deps_minimum.toml
Outdated
@@ -40,7 +40,6 @@ classifiers = [ | |||
'Programming Language :: Python :: 3', | |||
'Programming Language :: Python :: 3 :: Only', | |||
'Programming Language :: Python :: 3.8', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should Python :: 3.8 be removed as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Yes definitely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This is a testing file so not critical but still useful)
I think there are a few |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only looked at _typing.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Do we want to wait until we get closer to 3.0 release to merge?
I guess we could merge anytime, but I would wait a little just in case people are still using 3.9 nightlies |
Are people OK with doing this now? We're coming up on the Python 3.10 drop date (end of this year) as well. I would personally prefer dropping as close to the date specified by SPEC 0, so people aren't surprised when this happens. |
Since it seemed like there was approval a few months ago, I'll merge at the end of the week if there are no objections |
Works for me |
Dropping Python 3.9 support per NEP 29 and SPEC-0