BUG/TST: non-numeric EA reductions #59234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemanley
added
Bug
ExtensionArray
mroeschke
reviewed
Jul 12, 2024
pandas/core/arrays/string_.py
Outdated
| @@ -525,7 +525,10 @@ def _reduce( | |||
| self, name: str, *, skipna: bool = True, axis: AxisInt | None = 0, **kwargs | |||
| ): | |||
| if name in ["min", "max"]: | |||
| return getattr(self, name)(skipna=skipna, axis=axis) | |||
| result = getattr(self, name)(skipna=skipna, axis=axis) | |||
| if kwargs.get("keepdims"): | |||
There was a problem hiding this comment.
Could you include keepdims in the _reduce signature instead?
mroeschke
reviewed
Jul 12, 2024
| if name == "std": | ||
| from pandas.core.arrays import TimedeltaArray | ||
|
|
||
| return TimedeltaArray._from_sequence(result) |
There was a problem hiding this comment.
Does this possibly preserve the resolution of the input? e.g std of a ms resolution datetime array should return ms resolution
There was a problem hiding this comment.
yes, the resolution is preserved in nanops.nanstd.
mroeschke
approved these changes
Jul 13, 2024
|
Thanks @lukemanley |
lithomas1
added a commit
to lithomas1/pandas
that referenced
this pull request
Sep 9, 2024
jorisvandenbossche
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Oct 2, 2024
jorisvandenbossche
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Oct 2, 2024
jorisvandenbossche
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Oct 2, 2024
jorisvandenbossche
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Oct 3, 2024
jorisvandenbossche
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Oct 7, 2024
jorisvandenbossche
pushed a commit
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v3.0.0.rstfile if fixing a bug or adding a new feature.Fixes a few bugs related to non-numeric EA reductions and expands testing by un-skipping a number of existing tests.
BUG fix example: