-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Fix precision loss in read_json #59284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR - please add a test.
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
Yes please reopen this PR, I have merged the main branch. |
Hi @rhshadrach , is there anything else that needs to be changed in this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks good to me, just some requests on the test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies - one more request. I missed that there is no whatsnew note. Can you add a note in docs/source/whatsnew/v3.0.0
in the I/O
section.
Thanks, I have updated the whatsnew |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks @fawazahmed0! |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.