Skip to content

BUG: Fix precision loss in read_json #59284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Sep 24, 2024
Merged

Conversation

fawazahmed0
Copy link
Contributor

@fawazahmed0 fawazahmed0 commented Jul 20, 2024

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR - please add a test.

@rhshadrach rhshadrach added Bug Dtype Conversions Unexpected or buggy dtype conversions IO JSON read_json, to_json, json_normalize labels Jul 23, 2024
@fawazahmed0 fawazahmed0 requested a review from rhshadrach August 1, 2024 18:17
@fawazahmed0 fawazahmed0 requested a review from rhshadrach August 1, 2024 22:30
Copy link
Contributor

github-actions bot commented Sep 1, 2024

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Sep 1, 2024
@rhshadrach
Copy link
Member

pre-commit.ci autofix

@mroeschke
Copy link
Member

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

@mroeschke mroeschke closed this Sep 15, 2024
@fawazahmed0 fawazahmed0 changed the title Fix https://github.com/pandas-dev/pandas/issues/20608 Fix precision loss in read_json Sep 18, 2024
@fawazahmed0
Copy link
Contributor Author

fawazahmed0 commented Sep 18, 2024

Yes please reopen this PR, I have merged the main branch.

@mroeschke mroeschke reopened this Sep 18, 2024
@fawazahmed0 fawazahmed0 changed the title Fix precision loss in read_json BUG: Fix precision loss in read_json Sep 19, 2024
@fawazahmed0
Copy link
Contributor Author

Hi @rhshadrach , is there anything else that needs to be changed in this PR

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good to me, just some requests on the test.

@rhshadrach rhshadrach removed the Stale label Sep 23, 2024
@rhshadrach rhshadrach added this to the 3.0 milestone Sep 23, 2024
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies - one more request. I missed that there is no whatsnew note. Can you add a note in docs/source/whatsnew/v3.0.0 in the I/O section.

@fawazahmed0
Copy link
Contributor Author

Thanks, I have updated the whatsnew

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach merged commit 2cdb97e into pandas-dev:main Sep 24, 2024
50 of 51 checks passed
@rhshadrach
Copy link
Member

Thanks @fawazahmed0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Dtype Conversions Unexpected or buggy dtype conversions IO JSON read_json, to_json, json_normalize
Projects
None yet
Development

Successfully merging this pull request may close these issues.

read_json reads large integers as strings incorrectly if dtype not explicitly mentioned
3 participants