REF (string dtype): rename using_pyarrow_string_dtype to using_string_dtype #59320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 26, 2024
mroeschke
approved these changes
Jul 26, 2024
mroeschke
added
the
Testing
|
Thanks @jorisvandenbossche |
WillAyd
pushed a commit
that referenced
this pull request
Aug 13, 2024
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 14, 2024
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 15, 2024
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 15, 2024
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 15, 2024
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 22, 2024
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 22, 2024
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 27, 2024
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Sep 20, 2024
jorisvandenbossche
added a commit
to WillAyd/pandas
that referenced
this pull request
Oct 2, 2024
jorisvandenbossche
added a commit
to WillAyd/pandas
that referenced
this pull request
Oct 2, 2024
jorisvandenbossche
added a commit
to WillAyd/pandas
that referenced
this pull request
Oct 3, 2024
jorisvandenbossche
added a commit
to WillAyd/pandas
that referenced
this pull request
Oct 7, 2024
jorisvandenbossche
added a commit
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #54792
This is a plain search-replace of
using_pyarrow_string_dtypewithusing_string_dtypeplus some automated formatting because of the change.Given the future string dtype will not be strictly backed by pyarrow, this general config helper to check if the future option is enabled can be better renamed (we might need a more specific check if we are using the pyarrow variant in certain cases later, but that can be added when needed), and given there are coming more PRs working on this, better to do this rename first.