Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF (string): Move StringArrayNumpySemantics methods to base class #59514

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@mroeschke
Copy link
Member

mypy.....................................................................Failed
- hook id: mypy
- duration: 80.69s
- exit code: 1

pandas/core/arrays/string_.py:841: error: Incompatible types in assignment (expression has type "BooleanArray", variable has type "ndarray[Any, dtype[Any]]")  [assignment]
pandas/core/arrays/string_.py:844: error: "ndarray[Any, dtype[Any]]" has no attribute "to_numpy"  [attr-defined]
pandas/core/arrays/string_.py:846: error: "ndarray[Any, dtype[Any]]" has no attribute "to_numpy"  [attr-defined]
Found 3 errors in 1 file (checked 1441 source files)

@mroeschke mroeschke added Refactor Internal refactoring of code Strings String extension data type and string data labels Aug 14, 2024
@mroeschke mroeschke added this to the 3.0 milestone Aug 14, 2024
@mroeschke mroeschke merged commit 0851ac3 into pandas-dev:main Aug 14, 2024
47 checks passed
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the ref-stringarray branch August 14, 2024 21:44
@jorisvandenbossche jorisvandenbossche modified the milestones: 3.0, 2.3 Aug 20, 2024
WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Aug 22, 2024
…andas-dev#59514)

* REF (string): Move StringArrayNumpySemantics methods to base class

* mypy fixup
WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Aug 22, 2024
…andas-dev#59514)

* REF (string): Move StringArrayNumpySemantics methods to base class

* mypy fixup
WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Aug 22, 2024
…andas-dev#59514)

* REF (string): Move StringArrayNumpySemantics methods to base class

* mypy fixup
WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Aug 22, 2024
…andas-dev#59514)

* REF (string): Move StringArrayNumpySemantics methods to base class

* mypy fixup
WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Aug 27, 2024
…andas-dev#59514)

* REF (string): Move StringArrayNumpySemantics methods to base class

* mypy fixup
WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Sep 20, 2024
…andas-dev#59514)

* REF (string): Move StringArrayNumpySemantics methods to base class

* mypy fixup
jorisvandenbossche pushed a commit to WillAyd/pandas that referenced this pull request Oct 2, 2024
…andas-dev#59514)

* REF (string): Move StringArrayNumpySemantics methods to base class

* mypy fixup
jorisvandenbossche pushed a commit to WillAyd/pandas that referenced this pull request Oct 2, 2024
…andas-dev#59514)

* REF (string): Move StringArrayNumpySemantics methods to base class

* mypy fixup
jorisvandenbossche pushed a commit to WillAyd/pandas that referenced this pull request Oct 3, 2024
…andas-dev#59514)

* REF (string): Move StringArrayNumpySemantics methods to base class

* mypy fixup
jorisvandenbossche pushed a commit to WillAyd/pandas that referenced this pull request Oct 7, 2024
…andas-dev#59514)

* REF (string): Move StringArrayNumpySemantics methods to base class

* mypy fixup
jorisvandenbossche pushed a commit that referenced this pull request Oct 9, 2024
…59514)

* REF (string): Move StringArrayNumpySemantics methods to base class

* mypy fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported Refactor Internal refactoring of code Strings String extension data type and string data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants