-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: groupby.agg with UDF changing pyarrow dtypes #59601
Draft
rhshadrach
wants to merge
40
commits into
pandas-dev:main
Choose a base branch
from
rhshadrach:fix/group_by_agg_pyarrow_bool_numpy_same_type
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
BUG: groupby.agg with UDF changing pyarrow dtypes #59601
rhshadrach
wants to merge
40
commits into
pandas-dev:main
from
rhshadrach:fix/group_by_agg_pyarrow_bool_numpy_same_type
+112
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unt for missing pyarrow dtypes
…b.com:undermyumbrella1/pandas into fix/group_by_agg_pyarrow_bool_numpy_same_type
rhshadrach
added
Groupby
Arrow
pyarrow functionality
pyarrow dtype retention
op with pyarrow dtype -> expect pyarrow result
Bug
and removed
Arrow
pyarrow functionality
labels
Aug 25, 2024
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
rhshadrach
changed the title
Fix/group by agg pyarrow bool numpy same type
BUG: groupby.agg with UDF changing pyarrow dtypes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #58129
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.Root cause:
agg_series
always forces output dtype to be the same as input dtype, but depending on the lambda, the output dtype can be differentFix:
maybe_convert_object
, asmaybe_convert_object
does not check for NA, and forces dtype to float if NA is present (NA is not float in pyarrow),