-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH: Add sym_diff for index #6016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Good call on not requiring Yahoo network errors are causing the failure. I'll retry later. |
@TomAugspurger if you rebase on master the network errors should go away...@y-p fixed this |
I guess I forgot to fetch before rebasing. I'll throw in a release notes entry once the .14 cycle starts. |
@TomAugspurger Two ideas for the documentation of someone not so familiar with set terminology:
|
@TomAugspurger FYI, you should enable the operator '^' e.g. see here: http://docs.python.org/2/library/sets.html (you define |
Thanks. @jorisvandenbossche added more to notes and an example. @jreback I didn't know that python used |
@TomAugspurger Thanks for the clarifications! |
@TomAugspurger looks good...pls add release notes / maybe add that you can do this in indexing section (where the descriptin of the Index internal methods are - near the bottom) |
update release and docs
@jreback rebased and added notes and docs. Should be good to go. |
gr8! pls review the release notes/v0.14.0 after this is built this is built when master processes this PR: http://pandas-docs.github.io/pandas-docs-travis/ thanks! |
Will do. Thanks. |
this test fails on python 3.4 (only tested on windows atm) any ideas?
|
Strange. I'll get a 3.4 env setup and see what's going on. |
note...that we don't test on travis 3.4 Here's my setup of 34-32 (34-64 fails too)
|
@TomAugspurger Do you remember the background of adding Should be added to others if it's useful, otherwise deprecate? |
Huh, I have no idea. I don't know that I've ever used it, so I'm not sure why I included that. |
Close #5543
If there's any interest for this in 0.14, here's the code.
Thoughts on the method name? A regular difference is
diff
so I want to be consistent with that. I figured it would be a bit weird to truncatedifference
todiff
but not truncatesymmetric
tosym
(orsymm
) so I went withsym_diff
(python sets usesymmetric_difference
).Also when writing the tests, I discovered that NaNs are even weirder than I thought:
Seems like neither
set
norsorted
did anything. Anyway my PR should be consistent with this weirdness.