Skip to content

ERR (string dtype): harmonize setitem error message for python and pyarrow storage #60219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jorisvandenbossche
Copy link
Member

Related to #60218, but just already making sure we have the same error message for the string dtype for pyarrow vs python storage.

@jorisvandenbossche jorisvandenbossche added Error Reporting Incorrect or improved errors from pandas Strings String extension data type and string data labels Nov 6, 2024
@jorisvandenbossche jorisvandenbossche added this to the 2.3 milestone Nov 6, 2024
@WillAyd WillAyd merged commit 692ea6f into pandas-dev:main Nov 7, 2024
51 checks passed
Copy link

lumberbot-app bot commented Nov 7, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.3.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 692ea6f9d4b05187a05f0811d3241211855d6efb
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #60219: ERR (string dtype): harmonize setitem error message for python and pyarrow storage'
  1. Push to a named branch:
git push YOURFORK 2.3.x:auto-backport-of-pr-60219-on-2.3.x
  1. Create a PR against branch 2.3.x, I would have named this PR:

"Backport PR #60219 on branch 2.3.x (ERR (string dtype): harmonize setitem error message for python and pyarrow storage)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@jorisvandenbossche
Copy link
Member Author

Manual backport -> #60232

jorisvandenbossche added a commit that referenced this pull request Nov 8, 2024
…for python and pyarrow storage (#60219) (#60232)

(cherry picked from commit 692ea6f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Error Reporting Incorrect or improved errors from pandas Strings String extension data type and string data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants