Fix arrow groupby na #60777
Open
Fix arrow groupby na #60777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asharmalik19
force-pushed
the
fix-arrow-groupby-na
branch
4 times, most recently
from
0e61611 to
66330ee
Compare
rhshadrach
requested changes
Jan 30, 2025
asharmalik19
force-pushed
the
fix-arrow-groupby-na
branch
2 times, most recently
from
273d85f to
226ae6c
Compare
asharmalik19
force-pushed
the
fix-arrow-groupby-na
branch
3 times, most recently
from
f973800 to
72beba9
Compare
rhshadrach
approved these changes
Feb 8, 2025
asharmalik19
force-pushed
the
fix-arrow-groupby-na
branch
2 times, most recently
from
4ffc234 to
4d82464
Compare
|
The CI is now green. @rhshadrach can you please merge this PR. |
mroeschke
reviewed
Feb 10, 2025
| encoded = data | ||
| if null_encoding == "encode": | ||
| # dictionary encode does nothing if an already encoded array is given | ||
| data = data.cast(data.type.value_type) |
There was a problem hiding this comment.
Can you use dictionary_decode() instead?
There was a problem hiding this comment.
dictionary_decode() works on the DictionaryArray while the input to factorize() function is a ChunkedArray. So the chunked array first needs to be combined into a dictionary array and then the dictionary_decode() can be used on it which i think is more inefficient as compared to simply casting the array to its underlying data type.
asharmalik19
force-pushed
the
fix-arrow-groupby-na
branch
from
4d82464 to
273e998
Compare
asharmalik19
requested review from
noatamir and
datapythonista
as code owners
asharmalik19
force-pushed
the
fix-arrow-groupby-na
branch
2 times, most recently
from
4952817 to
59a4668
Compare
…d backwards compatibility maintained
asharmalik19
force-pushed
the
fix-arrow-groupby-na
branch
from
59a4668 to
6ca56d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v3.0.0.rstfile for the bug fix.