BLD: allow to build with non-MSVC compilers on Windows #61404
+4
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always passing --vsenv to meson means pandas can't be built with gcc/clang on Windows. Instead add it to the cibuildwheel config so MSVC is still forced in CI when building wheels, and in various places where it is built via pip.
|
I understand that this is an edge case on Windows, and that mingw is not officially supported, but numpy/scipy also don't force msvc, so I though it's worth a try proposing this. Feedback welcome. |
|
Thanks for the PR. This makes sense, although I think the challenge is more comprehensively how we document the process for users that want to build on Windows. I have pretty limited Windows knowledge, but AFAIU we only document currently for the MSVC approach? So if we want to go this route, I think just need to make it clearer to contributors how they can opt in or out of the the different toolchains on Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always passing --vsenv to meson means pandas can't be built with gcc/clang
on Windows.
Instead add it to the cibuildwheel config so MSVC is still forced in CI
when building wheels, and in various places where it is built via pip.