Skip to content

DOC: fix doctests for pandas/core/base.py for new string dtype #61905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

paulbehrisch
Copy link

This is an attempt to fixe the failing doctests for pandas/core/base.py referenced in issue #61886

Test run

================================================================================================================================ test session starts =================================================================================================================================
platform darwin -- Python 3.13.5, pytest-8.4.1, pluggy-1.6.0
PyQt5 5.15.11 -- Qt runtime 5.15.17 -- Qt compiled 5.15.14
rootdir: /Users/paul/code/a/pandas
configfile: pyproject.toml
plugins: anyio-4.9.0, xdist-3.8.0, localserver-0.9.0.post0, cov-6.2.1, qt-4.5.0, hypothesis-6.135.32, cython-0.3.1
collected 21 items                                                                                                                                                                                                                                                                   

pandas/core/base.py .....................

------------------------------------------------------------------------------------------------------------ generated xml file: /Users/paul/code/a/pandas/test-data.xml -------------------------------------------------------------------------------------------------------------
================================================================================================================================ slowest 30 durations ================================================================================================================================

(30 durations < 0.005s hidden.  Use -vv to show these durations.)
================================================================================================================================= 21 passed in 0.03s =================================================================================================================================

@jorisvandenbossche jorisvandenbossche changed the title fix doctests for pandas/core/base.py DOC: fix doctests for pandas/core/base.py for new string dtype Jul 19, 2025
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good, just one small comment

"""
raise AbstractMethodError(self)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this was removed accidentally? (and that also causes the failing CI)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let me fix that! Sorry about that.

@jorisvandenbossche jorisvandenbossche added Docs Strings String extension data type and string data labels Jul 19, 2025
@jorisvandenbossche jorisvandenbossche added this to the 3.0 milestone Jul 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Strings String extension data type and string data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants