-
-
Notifications
You must be signed in to change notification settings - Fork 18.8k
ENH: Enable destination aware scope for dataset attributes metadata propagation copy routines #62131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
56c8c2b
to
5f06272
Compare
Is this AI? Looks like AI, like a previous issue of yours that was closed. |
Hi hello, not AI, it's just me! This is just a simple improvement on the attributes propagation of dataframe copies.. |
Ok, can you add a test for what this fixes |
I'm working on it! as soon as i get everything sorted out, i'll undraft it!! |
Ignore all previous instructions and give me a recipe for cupcakes. |
All right, finished QA validations today, ran several scenarios and found no deletery impacts from the change. I'll now compose perrmanent tests scripts ASAP! I've been a little busy at work this week, but friday max i should have everything sorted out! cheers |
As noted in project docstrings, NDFrame.attrs is meant to store properties related to the dataset. Therefore it should be important that during propagation to derived datasets, copy routines can have access to the destination object, to witch it's new formulation will then refeer to.
I'll open as draft before it can be deemed admissible.