Skip to content

ENH: improve error message when specifying a previously-deprecated frequen… #62539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 5, 2025
Merged

ENH: improve error message when specifying a previously-deprecated frequen… #62539

merged 9 commits into from
Oct 5, 2025
+35 −7

Conversation

jgao8
Copy link
Contributor

@jgao8 jgao8 commented Oct 1, 2025 •
edited by mroeschke
Loading

@jgao8 jgao8 changed the title improve error message when specifying a previously-deprecated frequen… ENH: improve error message when specifying a previously-deprecated frequen… Oct 2, 2025
WillAyd
WillAyd approved these changes Oct 2, 2025
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a nice PR - well done! @jorisvandenbossche @mroeschke any feedback?

@mroeschke mroeschke added Error Reporting Incorrect or improved errors from pandas Frequency DateOffsets labels Oct 2, 2025
mroeschke
mroeschke requested changes Oct 2, 2025
View reviewed changes
@jgao8 jgao8 force-pushed the improve-error-msg-freq branch from 326909b to 931610a Compare October 3, 2025 02:31
mroeschke
mroeschke reviewed Oct 3, 2025
View reviewed changes
mroeschke
mroeschke requested changes Oct 3, 2025
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to remove INVALID_FREQ_ERR_MSG now

@jgao8
Copy link
Contributor Author

jgao8 commented Oct 3, 2025

It seems that INVALID_FREQ_ERR_MSG is used in other files, including tests in test_round.py, which check for the presence of Invalid frequency in the error message.

@mroeschke mroeschke added this to the 3.0 milestone Oct 5, 2025
@mroeschke mroeschke merged commit 32ea61d into pandas-dev:main Oct 5, 2025
42 checks passed
@mroeschke
Copy link
Member

Thanks @jgao8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Error Reporting Incorrect or improved errors from pandas Frequency DateOffsets
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

ERR: improve error message when specifying a previously-deprecated frequency alias
3 participants
@jgao8 @mroeschke @WillAyd