Fix variance calculation for complex numbers by preserving dtype #62555
+27
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaurya5
force-pushed
the
sg/issue-62421
branch
from
05e6f08 to
f42afd3
Compare
WillAyd
requested changes
Oct 3, 2025
|
|
||
| ser2 = Series([1 + 2j, 2 + 3j, 3 + 4j], dtype=np.complex128) | ||
| expected_var = 2.0 | ||
| tm.assert_almost_equal(ser2.var(ddof=1), expected_var) |
There was a problem hiding this comment.
Do we need assert_almost_equal or can we use assert_series_equal?
There was a problem hiding this comment.
We need assert_almost_equal because .var() will return a scalar not a series
There was a problem hiding this comment.
Can you instead adjust the expected value to be the right type of output? The point of assert_almost_equal is to allow for differences in precision, but not necessarily in types
| ser2.var(ddof=1), np.var([1 + 2j, 2 + 3j, 3 + 4j], ddof=1) | ||
| ) | ||
|
|
||
| # Test with NaN |
There was a problem hiding this comment.
Rather than creating multiple variables it would be better to parametrize the inputs to this test
| # Test other ddof values | ||
| tm.assert_almost_equal(ser2.var(ddof=0), 4 / 3) | ||
|
|
||
| # Test that imaginary part is preserved in mean calculation |
There was a problem hiding this comment.
This looks like it should be a separate test
shaurya5
force-pushed
the
sg/issue-62421
branch
from
f42afd3 to
890d79b
Compare
shaurya5
force-pushed
the
sg/issue-62421
branch
from
890d79b to
0af9ccd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.