STY: Enforce Ruff rule B905 for pandas/tests #62564
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alvaro-Kothe
suggested changes
Oct 4, 2025
| if isinstance(key, np.ndarray) and key.dtype == "bool": | ||
| # masking | ||
| for i, (k, v) in enumerate(zip(key, value)): | ||
| for i, (k, v) in enumerate(zip(key, value, strict=False)): |
There was a problem hiding this comment.
When value is assigned to cycle it should be strict=False otherwise, I think it can be strict=True.
| self.data[i] = v | ||
| else: | ||
| for k, v in zip(key, value): | ||
| for k, v in zip(key, value, strict=False): |
| # non-unique - wheee! | ||
| nu_df = DataFrame( | ||
| list(zip(range(3), range(-3, 1), list("abc"))), columns=["a", "a", "b"] | ||
| list(zip(range(3), range(-3, 1), list("abc"), strict=False)), |
There was a problem hiding this comment.
Suggested change
| list(zip(range(3), range(-3, 1), list("abc"), strict=False)), | |
| list(zip(range(3), range(-3, 0), list("abc"), strict=True)), |
| result = gb.apply(lambda grp: pd.DataFrame({"values": range(len(grp))})) | ||
|
|
||
| mi_tuples = tuple(zip(data["groups"], selected_data["values"])) | ||
| mi_tuples = tuple(zip(data["groups"], selected_data["values"], strict=False)) |
| expecteds = [DataFrame(values, index=index) for (values, index) in expected] | ||
|
|
||
| for expected, actual in zip(expecteds, df.expanding(min_periods)): | ||
| for expected, actual in zip(expecteds, df.expanding(min_periods), strict=False): |
There was a problem hiding this comment.
Which test cases require this to be marked as False?
|
|
||
| for expected, actual in zip(expecteds, df.rolling(window, min_periods=min_periods)): | ||
| for expected, actual in zip( | ||
| expecteds, df.rolling(window, min_periods=min_periods), strict=False |
There was a problem hiding this comment.
Which test cases require this to be marked as False?
| DataFrame(values, index=df.loc[index, "C"]) for (values, index) in expected | ||
| ] | ||
| for expected, actual in zip(expecteds, df.rolling(window, on="C")): | ||
| for expected, actual in zip(expecteds, df.rolling(window, on="C"), strict=False): |
There was a problem hiding this comment.
Which test cases require this to be marked as False?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #62434
This PR enforces Ruff rule B905 (
zip-without-explicit-strict) across the pandas test suite by addingstrict=Trueto all relevantzip()calls inpandas/tests.zip(...)in test files to usezip(..., strict=True)where appropriate.Checklist:
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Please let me know if any changes are needed!