-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
DOC: Set __module__ attributes and remove core from documentation
#62727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
core from documentation
core from documentationcore from documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
thanks @rhshadrach |
We already did it for the majority of functions in the top-level namespace in practice, so opened #62758 to finish that (at least for the top-level namespace) |
|
And @rhshadrach thanks a lot for this PR!! |
__module__on top-level public objects #55178 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.This PR addresses all
__module__attributes of public objects that I can find with the exception of functions. It's not clear to me if we want to also be modifying the__module__attribute of e.g.pandas.factorizeand even if we do, I'd like to keep that separate as this PR is already becoming sizable.Remaining documentation that contains
.core.:API docs
User Guide
Getting Started
no output.