Skip to content

Conversation

@xoxonut
Copy link
Contributor

@xoxonut xoxonut commented Jan 4, 2026

Replaced @doc decorator with hardcoded docstrings in pandas/io/excel/_calamine.py:

  • CalamineReader.init: Inlined storage_options docstring and removed the @doc decorator.
  • Removed unused imports (doc, _shared_docs).

@xoxonut xoxonut requested a review from rhshadrach as a code owner January 4, 2026 15:03
@xoxonut xoxonut changed the title inline docstring in CalamineReader DOC: inline docstring in CalamineReader Jan 4, 2026
@xoxonut
Copy link
Contributor Author

xoxonut commented Jan 4, 2026

pre-commit.ci autofix

@rhshadrach
Copy link
Member

The docs build recently stopped running and has now been fixed on main. Can you merge main, then will take a look.

@xoxonut
Copy link
Contributor Author

xoxonut commented Jan 5, 2026

Merged main and all checks passed. Ready for review! Thanks.

Comment on lines 51 to 58
Extra options that make sense for a particular storage connection, e.g.
host, port, username, password, etc. For HTTP(S) URLs the key-value pairs
are forwarded to ``urllib.request.Request`` as header options. For other
URLs (e.g. starting with "s3://", and "gcs://") the key-value pairs are
forwarded to ``fsspec.open``. Please see ``fsspec`` and ``urllib`` for more
details, and for more examples on storage options refer `here
<https://pandas.pydata.org/docs/user_guide/io.html?
highlight=storage_options#reading-writing-remote-files>`_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you indent this entire description?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review! I've updated the indentation as requested.

@mroeschke mroeschke added the Docs label Jan 5, 2026
@mroeschke mroeschke added this to the 3.0 milestone Jan 6, 2026
@mroeschke mroeschke merged commit fd69f4e into pandas-dev:main Jan 6, 2026
42 checks passed
@mroeschke
Copy link
Member

Thanks @xoxonut

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants