Skip to content

CLN: Specialize assert_(np.array_equal(...)) #6368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2014
Merged

CLN: Specialize assert_(np.array_equal(...)) #6368

merged 1 commit into from
Feb 16, 2014

Conversation

bwignall
Copy link
Contributor

Work on #6175. Work in progress. One more commit needed to finish; splitting to keep reasonably sized.

@bwignall
Copy link
Contributor Author

The proposed API change affects a function @KTAtkinson added this week. I changed all instances in master.

Tests still pass locally.

@jreback
Copy link
Contributor

jreback commented Feb 16, 2014

pls rebase on master - lots of recent changes

Work on #6175. Work in progress. One more commit needed to finish; splitting to keep reasonably sized.

* Changes assert_numpy_array_equals to assert_numpy_array_equal, for consistency with other methods. (API change of recently-added function)
* Changes instances of assert_(np.array_equal(A,B)) to assert_numpy_array_equal(A,B)
* Update release.rst to reflect work on #6175
@bwignall
Copy link
Contributor Author

@jreback: should be all set.

jreback added a commit that referenced this pull request Feb 16, 2014
CLN: Specialize assert_(np.array_equal(...))
@jreback jreback merged commit 8393651 into pandas-dev:master Feb 16, 2014
@jreback
Copy link
Contributor

jreback commented Feb 16, 2014

@bwignall thanks again!

@jreback jreback added this to the 0.14.0 milestone Feb 16, 2014
@bwignall bwignall deleted the assert_6175_arrayequal_1 branch February 18, 2014 03:21
gouthambs pushed a commit to gouthambs/pandas that referenced this pull request Mar 12, 2014
Work on pandas-dev#6175. This is the third (and final) "half" of the work started in pandas-dev#6368.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants